[
https://issues.apache.org/jira/browse/EAGLE-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15436322#comment-15436322
]
ASF GitHub Bot commented on EAGLE-500:
--------------------------------------
GitHub user anyway1021 opened a pull request:
https://github.com/apache/incubator-eagle/pull/387
[EAGLE-500] fix process-stopping issue of mongodb unit test case
https://issues.apache.org/jira/browse/EAGLE-500
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anyway1021/incubator-eagle EAGLE-500
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/387.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #387
----
commit 4486bbb1b8f4de35ce2a1a764c1f63610169e8c4
Author: anyway1021 <[email protected]>
Date: 2016-08-25T05:29:58Z
[EAGLE-500] fix process-stopping issue of mongodb unit test case
----
> inaccurate IllegalStateException not caught within unit-test-cases when
> MongoDB normal stop() fails
> ---------------------------------------------------------------------------------------------------
>
> Key: EAGLE-500
> URL: https://issues.apache.org/jira/browse/EAGLE-500
> Project: Eagle
> Issue Type: Bug
> Reporter: Michael Wu
> Assignee: Michael Wu
>
> Looking at stopOrDestroyProcess() and waitForProcessGotKilled() methods of
> de.flapdoodle.embed.process.runtime.ProcessControl.java, when the returnCode
> returns from stopOrDestroyProcess() with "null", the process should have been
> destroyed by a native method implementation.
> So, the IllegalStateException thrown from waitForProcessGotKilled() seem not
> very accurate because it doesn't reflect the state of destroying result.
> To avoid false failure led by this issue in unit-test-case teardown(), I'd
> try catching the IllegalStateException when calling stop() of the
> MongodProcess instance, and filter the exception message "Couldn't kill .+
> process!".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
