[
https://issues.apache.org/jira/browse/EAGLE-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Chen updated EAGLE-454:
---------------------------
Description: Currently we are faced a problem that we can't close the pull
request from contributors automatically. When a pull request is merged in
develop branch, github could not close the pull request automatically and
committers don't have permission to close the pull request manually on github
page, so that we have to ask the contributor to close the branch manually
otherwise there would be lots of "OPEN" pull requests listed though most are
merged. Learning from github service: " To close this pull request, make a
commit to your *master/trunk *branch with (at least) the following in the
commit message: This closes #305 " Commits with *"Closes #PULL-REQUEST-ID"*
will only work on master/trunk, in fact *trunk* branch should be our *develo
*in purpose and would be better for management. Any comments are appreciated.
> Use master as main development branch
> -------------------------------------
>
> Key: EAGLE-454
> URL: https://issues.apache.org/jira/browse/EAGLE-454
> Project: Eagle
> Issue Type: Improvement
> Reporter: Hao Chen
> Assignee: Hao Chen
>
> Currently we are faced a problem that we can't close the pull request from
> contributors automatically. When a pull request is merged in develop branch,
> github could not close the pull request automatically and committers don't
> have permission to close the pull request manually on github page, so that we
> have to ask the contributor to close the branch manually otherwise there
> would be lots of "OPEN" pull requests listed though most are merged.
> Learning from github service: " To close this pull request, make a commit to
> your *master/trunk *branch with (at least) the following in the commit
> message: This closes #305 " Commits with *"Closes #PULL-REQUEST-ID"* will
> only work on master/trunk, in fact *trunk* branch should be our *develo *in
> purpose and would be better for management. Any comments are appreciated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
