[
https://issues.apache.org/jira/browse/EAGLE-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565800#comment-15565800
]
ASF GitHub Bot commented on EAGLE-609:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/492#discussion_r82824325
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert-app/src/main/resources/META-INF/providers/org.apache.eagle.alert.app.AlertUnitTopologyAppProvider.xml
---
@@ -25,6 +25,12 @@
<configuration>
<!-- alert topology sizing parameters -->
<property>
+ <name>topology.name</name>
+ <displayName>topology.name</displayName>
+ <value>alertUnitTopology_1</value>
--- End diff --
I think we should not keep current implementation only supporting
hard-coded "alertUnitTopology_1", and coordinator should be able to easily fix
it to use actual topology name accordingly.
> NullPointerException in DefaultDeduplicator
> -------------------------------------------
>
> Key: EAGLE-609
> URL: https://issues.apache.org/jira/browse/EAGLE-609
> Project: Eagle
> Issue Type: Bug
> Affects Versions: 0.5
> Reporter: Zhao, Qingwen
> Assignee: Zhao, Qingwen
> Fix For: 0.5
>
>
> {code}
> // make all of the field as unique key if no custom dedup field provided
> if (customDedupFields == null || customDedupFields.size() <= 0) {
> customFieldValues.put(colName, event.getData()[i].toString());
> } else {
> for (String field : customDedupFields) {
> if (colName.equals(field)) {
> customFieldValues.put(field,
> event.getData()[i].toString());
> break;
> }
> }
> }
> {code}
> In the above code, if the value of colName is null, then nullPointerException
> is thrown
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
