[
https://issues.apache.org/jira/browse/EAGLE-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593768#comment-15593768
]
ASF GitHub Bot commented on EAGLE-652:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/546#discussion_r84412447
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/extractor/hdfs/HdfsTopologyEntityParser.java
---
@@ -220,7 +220,7 @@ private void createAllDataNodeEntities(JMXBean bean,
long updateTime, TopologyEn
final String hostname = liveNodes.getString(i);
final JSONObject liveNode =
jsonNodesObject.getJSONObject(hostname);
- HdfsServiceTopologyAPIEntity entity =
createHdfsServiceEntity(TopologyConstants.DATA_NODE_ROLE, hostname, updateTime);
+ HdfsServiceTopologyAPIEntity entity =
createHdfsServiceEntity(TopologyConstants.DATA_NODE_ROLE,
EntityBuilderHelper.getValidHostName(hostname), updateTime);
final Number configuredCapacity = (Number)
liveNode.get(DATA_NODE_CAPACITY);
entity.setConfiguredCapacityTB(Double.toString(configuredCapacity.doubleValue()
/ 1024.0 / 1024.0 / 1024.0 / 1024.0));
--- End diff --
Use static final value `Long TB = 1024.0*1024.0*1024.0*1024.0` then use
~~~
entity.setConfiguredCapacityTB(Double.toString(configuredCapacity.doubleValue()
/ TB));
~~~
> services health check for hdfs,hbase and yarn
> ---------------------------------------------
>
> Key: EAGLE-652
> URL: https://issues.apache.org/jira/browse/EAGLE-652
> Project: Eagle
> Issue Type: New Feature
> Affects Versions: v0.5.0
> Reporter: yupu
> Labels: features
>
> The app aims to monitor those services with a master-slave structured
> topology, and provides metrics at the HOST level. Specifically, this app will
> support the following services healthy check
> •HDFS: namenode, datanode, journalnode
> •HBASE: hmaster, regionservers
> YARN: resourcemanager, nodemanagers, historyserver
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
