Github user puyulu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/546#discussion_r84413424
--- Diff:
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/extractor/hdfs/HdfsTopologyEntityParser.java
---
@@ -220,7 +220,7 @@ private void createAllDataNodeEntities(JMXBean bean,
long updateTime, TopologyEn
final String hostname = liveNodes.getString(i);
final JSONObject liveNode =
jsonNodesObject.getJSONObject(hostname);
- HdfsServiceTopologyAPIEntity entity =
createHdfsServiceEntity(TopologyConstants.DATA_NODE_ROLE, hostname, updateTime);
+ HdfsServiceTopologyAPIEntity entity =
createHdfsServiceEntity(TopologyConstants.DATA_NODE_ROLE,
EntityBuilderHelper.getValidHostName(hostname), updateTime);
final Number configuredCapacity = (Number)
liveNode.get(DATA_NODE_CAPACITY);
entity.setConfiguredCapacityTB(Double.toString(configuredCapacity.doubleValue()
/ 1024.0 / 1024.0 / 1024.0 / 1024.0));
--- End diff --
changed the hard code to final value
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
