[
https://issues.apache.org/jira/browse/EAGLE-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597150#comment-15597150
]
ASF GitHub Bot commented on EAGLE-662:
--------------------------------------
Github user haoch commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/550#discussion_r84570146
--- Diff:
eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/service/ApplicationAction.java
---
@@ -70,13 +71,16 @@ public ApplicationAction(Application application,
ApplicationEntity metadata, Co
this.application = application;
this.metadata = metadata;
this.runtime =
ExecutionRuntimeManager.getInstance().getRuntime(application.getEnvironmentType(),
serverConfig);
- Map<String, Object> executionConfig = metadata.getConfiguration();
+ Map<String, Object> executionConfig = new
HashMap<>(metadata.getConfiguration());
if (executionConfig == null) {
executionConfig = Collections.emptyMap();
}
if (serverConfig.hasPath(MetricConfigs.METRIC_PREFIX_CONF)) {
LOG.warn("Ignored sever config {} = {}",
MetricConfigs.METRIC_PREFIX_CONF,
serverConfig.getString(MetricConfigs.METRIC_PREFIX_CONF));
}
+
+ executionConfig.put("jarPath", metadata.getJarPath());
+ executionConfig.put("mode", metadata.getMode().name());
--- End diff --
It may cause the jarPath added into configuration when installating, I
think you should add only in `start` action.
> remove jarPath/mode from entity context
> ---------------------------------------
>
> Key: EAGLE-662
> URL: https://issues.apache.org/jira/browse/EAGLE-662
> Project: Eagle
> Issue Type: Bug
> Affects Versions: v0.5.0
> Reporter: wujinhu
> Assignee: wujinhu
> Fix For: v0.5.0
>
>
> remove jarPath/mode from application entity context, because they may be
> changed by user after application is installed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
