[
https://issues.apache.org/jira/browse/EAGLE-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600646#comment-15600646
]
ASF GitHub Bot commented on EAGLE-672:
--------------------------------------
GitHub user garrettlish opened a pull request:
https://github.com/apache/incubator-eagle/pull/553
EAGLE-672: remove mongo state store for dedup
Currently the MongoStateStore is not a common use case for eagle, we need
to remove the specific use case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/garrettlish/incubator-eagle eagle672
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/553.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #553
----
commit 2d5a35e3b915651578f2764ffb99207504a8d4ca
Author: Xiancheng Li <[email protected]>
Date: 2016-10-24T01:32:21Z
EAGLE-672: remove mongo state store for dedup
----
> AlertEngine: MongoStateStore should be removed
> ----------------------------------------------
>
> Key: EAGLE-672
> URL: https://issues.apache.org/jira/browse/EAGLE-672
> Project: Eagle
> Issue Type: Task
> Affects Versions: v0.5.0
> Reporter: Su Ralph
> Assignee: Garrett Li
> Fix For: v0.5.0
>
>
> Below stack reported by Hao. We should not have mongo state store evolved in
> deployment that doesn't have mongo enabled. And the class have too much
> unreasonable hardcode field names. Please consider remove it.
> Stack:
> 2016-10-23 03:39:02 Thread-13
> org.apache.eagle.alert.engine.publisher.dedup.MongoDedupEventsStore [ERROR]
> find dedup state failed, but the state in memory is good, could be ingored.
> java.lang.NullPointerException: null
> at
> org.apache.eagle.alert.engine.publisher.dedup.MongoDedupEventsStore.getEvents(MongoDedupEventsStore.java:102)
> ~[stormjar.jar:na]
> at
> org.apache.eagle.alert.engine.publisher.dedup.DedupCache.getEvents(DedupCache.java:103)
> [stormjar.jar:na]
> at
> org.apache.eagle.alert.engine.publisher.dedup.DedupCache$2.run(DedupCache.java:81)
> [stormjar.jar:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [na:1.8.0_91]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> [na:1.8.0_91]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> [na:1.8.0_91]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> [na:1.8.0_91]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_91]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_91]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_91]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)