[
https://issues.apache.org/jira/browse/EAGLE-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614585#comment-15614585
]
ASF GitHub Bot commented on EAGLE-683:
--------------------------------------
Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/566#discussion_r85466419
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-metadata-parent/alert-metadata/src/main/java/org/apache/eagle/alert/metadata/impl/MongoMetadataDaoImpl.java
---
@@ -89,10 +92,37 @@
@Inject
public MongoMetadataDaoImpl(Config config) {
this.connection = config.getString("connection");
+ this.cappedSize = config.hasPath("cappedSize") ?
config.getInt("cappedSize") : 0;
--- End diff --
cappedSize default as 0? why not set it some reasonable value, and i saw
this is set as size in byte. should it be better to control the size in
document number. please check the maxDocuments in CreateCollectionOptions.
> AlertEngine : Improve metadata store performance
> ------------------------------------------------
>
> Key: EAGLE-683
> URL: https://issues.apache.org/jira/browse/EAGLE-683
> Project: Eagle
> Issue Type: Improvement
> Affects Versions: v0.5.0
> Reporter: Su Ralph
> Assignee: Zeng, Bryant
> Fix For: v0.5.0
>
>
> Currently, we enable periodically schedule in coordinator service itself. If
> this is enabled, the schedule spec will finally used up metadata storage.
> We should
> 1. Disable periodically schedule by default (storage like mysql doesn't have
> capped feature)
> 2. For mongodb storage, use capped collection for schedule_specs,
> policy_snapshots, streamSnapshots, groupSpecs, alertSpecs, monitoredStreams,
> spoutSpecs (all schedule spec related collection).
> Let use default config of 20,000 as capped collection size.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
