Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/566#discussion_r85466419
  
    --- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-metadata-parent/alert-metadata/src/main/java/org/apache/eagle/alert/metadata/impl/MongoMetadataDaoImpl.java
 ---
    @@ -89,10 +92,37 @@
         @Inject
         public MongoMetadataDaoImpl(Config config) {
             this.connection = config.getString("connection");
    +        this.cappedSize = config.hasPath("cappedSize") ? 
config.getInt("cappedSize") : 0;
    --- End diff --
    
    cappedSize default as 0? why not set it some reasonable value, and i saw 
this is set as size in byte.  should it be better to control the size in 
document number. please check the maxDocuments in CreateCollectionOptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to