[
https://issues.apache.org/jira/browse/EAGLE-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614513#comment-15614513
]
ASF GitHub Bot commented on EAGLE-697:
--------------------------------------
GitHub user anyway1021 opened a pull request:
https://github.com/apache/incubator-eagle/pull/578
[EAGLE-697] fix wrong url-concatenation for monitoring hadoop queue
For hadoop queue monitoring, when endpoint url doesn't end with a slash,
the final url will be composed by concatenating endpoint directly with resource
path. E.g.
endpoint: https://a.b.c:1111
resource path: ws/v1/cluster/some
Then final url is: https://a.b.c:1111ws/v1/cluster/some, which make
application fail.
We should add "/" to existing constants of resource paths, and compose
final url with utils.
Besides, add concrete unit test to guarantee this part functions normally.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anyway1021/incubator-eagle EAGLE-697
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #578
----
commit 8dd95bd25de917d81592292a2f245670106e6b4c
Author: anyway1021 <[email protected]>
Date: 2016-10-28T04:17:28Z
fix wrong url-concatenation for monitoring hadoop queue, also add unit tests
----
> wrong metric url composed when endpoint url doesn't end with a slash
> --------------------------------------------------------------------
>
> Key: EAGLE-697
> URL: https://issues.apache.org/jira/browse/EAGLE-697
> Project: Eagle
> Issue Type: Bug
> Reporter: Michael Wu
> Assignee: Michael Wu
>
> For hadoop queue monitoring, when endpoint url doesn't end with a slash, the
> final url will be composed by concatenating endpoint directly with resource
> path. E.g.
> endpoint: https://a.b.c:1111
> resource path: ws/v1/cluster/some
> Then final url is: https://a.b.c:1111ws/v1/cluster/some, which make
> application fail.
> We should add "/" to existing constants of resource paths, and compose final
> url with utils.
> Besides, add concrete unit test to guarantee this part functions normally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
