[ https://issues.apache.org/jira/browse/EAGLE-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625137#comment-15625137 ]
ASF GitHub Bot commented on EAGLE-717: -------------------------------------- GitHub user baibaichen opened a pull request: https://github.com/apache/incubator-eagle/pull/596 [EAGLE-717] Upgrade maven-surefire-plugin for supporting forkMode ( =… <!-- {% comment %} Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. {% endcomment %} --> Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- … always ) correctly Upgrade maven-surefire-plugin to 2.19.1 (latest version) You can merge this pull request into a Git repository by running: $ git pull https://github.com/baibaichen/incubator-eagle EAGLE-717 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/596.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #596 ---- commit a541e4921ef3fdc36c1b1fe22ea4180d376d506d Author: baibaichen <baibaic...@gmail.com> Date: 2016-11-01T11:02:29Z [EAGLE-717] Upgrade maven-surefire-plugin for supporting forkMode ( = always ) correctly Upgrade maven-surefire-plugin to 2.19.1 (latest version) ---- > Upgrade maven-surefire-plugin for supporting forkMode ( = always ) correctly > ---------------------------------------------------------------------------- > > Key: EAGLE-717 > URL: https://issues.apache.org/jira/browse/EAGLE-717 > Project: Eagle > Issue Type: Sub-task > Affects Versions: v0.5.0 > Reporter: Chang chen > Assignee: Chang chen > Fix For: v0.5.0 > > > Eagle UT need load siddhi string extension dynamically, but the current > maven-surefire-plugin is too old (2.6), and can't work correctly in always > forkMode which is needed for HBase UT. See [Class Loading and Forking in > Maven > Surefire|http://maven.apache.org/surefire/maven-surefire-plugin/examples/class-loading.html] > to understand how maven-surefire-plugin sets *java.class.path* and why. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)