[ https://issues.apache.org/jira/browse/EAGLE-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627887#comment-15627887 ]
ASF GitHub Bot commented on EAGLE-690: -------------------------------------- Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/570#discussion_r86078122 --- Diff: eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/TopologyCheckApp.java --- @@ -45,7 +63,16 @@ public StormTopology execute(Config config, StormEnvironment environment) { persistBoltName, new TopologyDataPersistBolt(topologyCheckAppConfig), topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt - ).setNumTasks(topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt).shuffleGrouping(spoutName); + ).setNumTasks(topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt).shuffleGrouping(spoutName); + + topologyBuilder.setBolt( + parseBoltName, + new HealthCheckParseBolt(), + topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt).shuffleGrouping(persistBoltName); + + logger.info("start to sink messsage to kafka"); --- End diff -- Storm topology is lazy execution, so in fact, current it's just defining the execution dataflow but not handle data at all, so `start to sink messsage to kafka` is not correct. > Integrate topology health check with alert engine > ------------------------------------------------- > > Key: EAGLE-690 > URL: https://issues.apache.org/jira/browse/EAGLE-690 > Project: Eagle > Issue Type: New Feature > Affects Versions: v0.5.0 > Reporter: yupu > Assignee: yupu > Labels: features > Fix For: v0.5.0 > > > Integrate topology health check with alert engine. > It will send timestamp,tag,status to alert engine,when the node status is > dead, alert engine will send the email to user -- This message was sent by Atlassian JIRA (v6.3.4#6332)