Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/570#discussion_r86078122
  
    --- Diff: 
eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/TopologyCheckApp.java
 ---
    @@ -45,7 +63,16 @@ public StormTopology execute(Config config, 
StormEnvironment environment) {
                 persistBoltName,
                 new TopologyDataPersistBolt(topologyCheckAppConfig),
                 topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt
    -        
).setNumTasks(topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt).shuffleGrouping(spoutName);
    +        
).setNumTasks(topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt).shuffleGrouping(spoutName);
        
    +       
    +        topologyBuilder.setBolt(
    +                   parseBoltName,
    +                   new HealthCheckParseBolt(),
    +                   
topologyCheckAppConfig.dataExtractorConfig.numEntityPersistBolt).shuffleGrouping(persistBoltName);
      
    +        
    +        logger.info("start to sink messsage to kafka");
    --- End diff --
    
    Storm topology is lazy execution, so in fact, current it's just defining 
the execution dataflow but not handle data at all, so `start to sink messsage 
to kafka` is not correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to