[ 
https://issues.apache.org/jira/browse/EAGLE-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632135#comment-15632135
 ] 

ASF GitHub Bot commented on EAGLE-729:
--------------------------------------

Github user wujinhu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/603#discussion_r86303727
  
    --- Diff: 
eagle-topology-check/eagle-topology-app/src/main/resources/META-INF/providers/org.apache.eagle.topology.TopologyCheckAppProvider.xml
 ---
    @@ -88,14 +88,20 @@
                 <description>Hbase Master Principal</description>
                 <value>hadoop/[email protected]</value>
             </property>
    -     
    +
             <property>
    -            <name>dataSourceConfig.hbase.kerberos.master.principal</name>
    -            <displayName>Hbase Master Principal</displayName>
    +            <name>dataSourceConfig.hbase.kerberos.eagle.principal</name>
    --- End diff --
    
    Does it work? I see the code
    
                hBaseConfig.hbaseMasterPrincipal = 
config.getString("dataSourceConfig.hbase.kerberos.master.principal");
    
    if (hBaseConfig.eaglePrincipal != null && hBaseConfig.eagleKeytab != null
                    && !hBaseConfig.eaglePrincipal.isEmpty() && 
!hBaseConfig.eagleKeytab.isEmpty()) {
                this.kerberosEnable = true;
                this.hBaseConfiguration.set("hbase.security.authentication", 
"kerberos");
                this.hBaseConfiguration.set("hbase.master.kerberos.principal", 
hBaseConfig.hbaseMasterPrincipal);
            }



> add hbase kerberose principle and keytab to provider
> ----------------------------------------------------
>
>                 Key: EAGLE-729
>                 URL: https://issues.apache.org/jira/browse/EAGLE-729
>             Project: Eagle
>          Issue Type: Improvement
>    Affects Versions: v0.5.0
>            Reporter: yupu
>            Assignee: yupu
>              Labels: features
>             Fix For: v0.5.0
>
>
> Add hbase kerberose principle and keytab to provider xml file



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to