[
https://issues.apache.org/jira/browse/EAGLE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15642999#comment-15642999
]
ASF GitHub Bot commented on EAGLE-728:
--------------------------------------
Github user wujinhu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/612#discussion_r86709972
--- Diff:
eagle-jpm/eagle-jpm-util/src/main/java/org/apache/eagle/jpm/util/JobNameNormalization.java
---
@@ -64,7 +67,7 @@ private JobNameNormalization() {
// load normalization rules
Config conf = ConfigFactory.load();
--- End diff --
Please remove this line(Config conf = ConfigFactory.load();) from code.
Since our application is a storm topology, it will be better if we pass
configure to it when we initialize it so that it won't load dynamically.
Please do a simple refactor and just pass Config object to this class.
> Application can't load application.properties when running local mode
> ---------------------------------------------------------------------
>
> Key: EAGLE-728
> URL: https://issues.apache.org/jira/browse/EAGLE-728
> Project: Eagle
> Issue Type: Bug
> Reporter: Lingang Deng
> Assignee: Lingang Deng
>
> When running local mode, jpm app can't get property
> "job.name.normalization.rules.key", then get exception
> {code}
> ERROR [2016-11-02 15:18:04,382]
> org.apache.eagle.jpm.mr.history.crawler.AbstractJobHistoryDAO: fail reading
> job history file
> ! java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.eagle.jpm.util.JobNameNormalization
> ! at
> org.apache.eagle.jpm.mr.history.parser.JHFEventReaderBase.handleJob(JHFEventReaderBase.java:199)
> ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at
> org.apache.eagle.jpm.mr.history.parser.JHFMRVer2EventReader.handleJobSubmitted(JHFMRVer2EventReader.java:187)
> ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at
> org.apache.eagle.jpm.mr.history.parser.JHFMRVer2EventReader.handleEvent(JHFMRVer2EventReader.java:53)
> ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at
> org.apache.eagle.jpm.mr.history.parser.JHFMRVer2Parser.parse(JHFMRVer2Parser.java:61)
> ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at
> org.apache.eagle.jpm.mr.history.crawler.DefaultJHFInputStreamCallback.onInputStream(DefaultJHFInputStreamCallback.java:58)
> ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at
> org.apache.eagle.jpm.mr.history.crawler.AbstractJobHistoryDAO.readFileContent(AbstractJobHistoryDAO.java:123)
> ~[eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at
> org.apache.eagle.jpm.mr.history.crawler.JHFCrawlerDriverImpl.crawl(JHFCrawlerDriverImpl.java:166)
> [eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at
> org.apache.eagle.jpm.mr.history.storm.JobHistorySpout.nextTuple(JobHistorySpout.java:160)
> [eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at
> backtype.storm.daemon.executor$fn__3373$fn__3388$fn__3417.invoke(executor.clj:565)
> [storm-core-0.9.3.jar:0.9.3]
> ! at backtype.storm.util$async_loop$fn__464.invoke(util.clj:463)
> [storm-core-0.9.3.jar:0.9.3]
> ! at clojure.lang.AFn.run(AFn.java:24)
> [eagle-topology-0.5.0-incubating-SNAPSHOT-assembly.jar:na]
> ! at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60]
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
