[
https://issues.apache.org/jira/browse/EAGLE-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662586#comment-15662586
]
ASF GitHub Bot commented on EAGLE-757:
--------------------------------------
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/648
LGTM, besides follow suggestions:
* Merge `alertDao` into `metadata.store`, probably by simply override
system property
* Handle possible runtime exception during object mapping.
> fix alert JdbcDatabaseHandler connection issue
> ----------------------------------------------
>
> Key: EAGLE-757
> URL: https://issues.apache.org/jira/browse/EAGLE-757
> Project: Eagle
> Issue Type: Bug
> Affects Versions: v0.5.0
> Reporter: wujinhu
> Assignee: wujinhu
> Fix For: v0.5.0
>
>
> 1. fix JdbcDatabaseHandler connection, could not share one connection
> 2. remove code like e.printStackTrace(); use log instead
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
