Jaechang Nam created EAGLE-844: ---------------------------------- Summary: Potential NPE issue Key: EAGLE-844 URL: https://issues.apache.org/jira/browse/EAGLE-844 Project: Eagle Issue Type: Bug Reporter: Jaechang Nam Priority: Minor
The following file accessed on Dec 18 2016 (Github revision id: 8fe968cb7e340e2f21711b5a0f701e760cb91d59), eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java, seems to have a potential null pointer exception. Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities(); if (entityServiceMap != null || entityServiceMap.values() != null) { for (EntityDefinition entityDefinition : entityServiceMap.values()) { createTable(entityDefinition); } } --- if entityServiceMap is null, entityServiceMap.values() could have NPE. I have no idea if entityServiceMap can be null. Having said that, at least it could be a code smell. -- This message was sent by Atlassian JIRA (v6.3.4#6332)