Hi Justin & Hen, I have made some changes about the third-party license, listed below:
<1> /src/util/number.js *https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/util/number.js <https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/util/number.js>* <2> /src/chart/treemap/treemapLayout.js *https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/chart/treemap/treemapLayout.js <https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/chart/treemap/treemapLayout.js>* <3> /src/chart/tree/layoutHelper.js *https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/chart/tree/layoutHelper.js <https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/chart/tree/layoutHelper.js>* <4> /src/chart/graph/forceHelper.js *https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/chart/graph/forceHelper.js <https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/chart/graph/forceHelper.js>* <5> /src/util/array/nest.js Removed because it is not needed essentially. <6> /src/scale/Time.js *https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/scale/Time.js <https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/src/scale/Time.js>* <7> LICENSE *https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/LICENSE <https://github.com/apache/incubator-echarts/blob/14cbb8008cbb8d3f058caaca6032209ecb000a1b/LICENSE>* Could you please check them again whether there is any inappropriate statement about the third-party license or copyright? If all OK, I will release a new candidate and initiate a new vote for it. Thanks, ------------------------------ Su Shuang (100pah) ------------------------------ On Sat, 16 Feb 2019 at 17:00, Hen <[email protected]> wrote: > On Fri, Feb 15, 2019 at 3:17 AM SHUANG SU <[email protected]> wrote: > > > > > > > Hi Hen, > > > > Thank you so much for the detailed checking. > > > > There is one more question about this file: > > > > > > <1> src/util/number.js > > > > > > > This file says this: > > > * @see < > > https://github.com/mbostock/d3/blob/master/src/arrays/quantile.js> > > > * @see <http://en.wikipedia.org/wiki/Quantile> > > > Assuming no code was copied, this seems fine. If code was copied from > > > either, then there is licensing to include (be that BSD for d3 or > > CC-BY-SA > > > for Quantile, the latter being a problem for us licensing wise). > > > > The method "quantile" in this file is only copied from the code of "d3" > > [1], which is under BSD. > > But the original code in "d3" [1] seems to use a formula on Wikipedia > [2]. > > So is it OK to use this "d3" code in "echarts" and only embed the BSD > > license of "d3" in the file "src/util/number.js" ? > > > > > > [1]. > > > https://github.com/d3/d3/blob/9cc9a875e636a1dcf36cc1e07bdf77e1ad6e2c74/src/arrays/quantile.js > > [2]. https://en.wikipedia.org/wiki/Quantile . Search "R-7" in this page, > > get the formula. > > > > > Yes that's okay, treat that as you do other BSD licensed code copied from > d3. > > The concept 'copied' from Wikipedia is the idea that a piece of mathematics > represents; the formula itself doesn't have copyrightable expression and > there's nothing else that appears to be being copied over from Wikipedia. > > Hen >
