I vote with +1 (binding). I checked as follows,
- The release files are in the correct location. - The word `incubating` is in the name. - The digital signature and hashes are correct. - DISCLAIMER, LICENSE, and NOTICE files exist and the text of each of them is correct. - NOTICE year is correct. - All source files have the ASF header. - Can compile successfully from source and the instruction is clear. Here is a minor issue: - The link to `Build Guide` seems to be incorrect. Thanks. On 2020/11/10 18:46:00, SHUANG SU <sushuang0...@gmail.com> wrote: > I am pleased to be calling this vote for the release of Apache ECharts > (incubating) 5.0.0 (release candidate 1). > > The release candidate to be voted over is available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/5.0.0-rc.1/ > > The release candidate is signed with a GPG key available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > The Git commit for this release is: > https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=d7658ec > > The Release Note is available in: > https://dist.apache.org/repos/dist/dev/incubator/echarts/5.0.0-rc.1/RELEASE_NOTE.txt > > Build Guide: > https://github.com/apache/incubator-echarts/blob/5.0.0-rc.1/README.md#build > > Doc for 5.0.0-rc.1: > https://echarts.apache.org/next/en/option.html > > Examples for 5.0.0-rc.1: > https://echarts.apache.org/next/examples/en/index.html > > > Please vote on releasing this package as: > Apache ECharts (incubating) 5.0.0 (release candidate 1) > by "2020-11-13T19:40:41.306Z". > > [ ] +1 Release this package > [ ] 0 I don't feel strongly about it, but don't object > [ ] -1 Do not release this package because... > > > > Thanks, > ------------------------------ > Su Shuang (100pah) > ------------------------------ > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
