+1

Checked:

- The release file is in the right location
- Version is correct in package.json
- LICENSE and NOTICE file exist
- NOTICE year correct
- RELEASE_NOTE.txt is correct
- Can build from source.


Thanks

*Ovilia*


On Fri, Apr 23, 2021 at 11:33 PM Yi Shen <shenyi....@gmail.com> wrote:

> Hi Ville. Thanks for the Vote!
>
> Sorry for missing this change. Will add it to the website.
>
> On Fri, Apr 23, 2021 at 11:27 PM Ville Brofeldt <
> ville.v.brofe...@gmail.com>
> wrote:
>
> > +1 (non-binding)
> >
> > Tested to work well with Apache Superset (master branch). I noticed that
> > https://github.com/apache/echarts/pull/14693 was missing on the release
> > note, but it seems to be included in the release which is most important.
> >
> > Ville
> >
> > On 23. Apr 2021, at 17.52, Yi Shen <shenyi....@gmail.com> wrote:
> >
> > Dear community,
> >
> > We are pleased to be calling this vote for the release of Apache ECharts
> > 5.1.1 (release candidate 1).
> >
> > The release candidate to be voted over is available at:
> > https://dist.apache.org/repos/dist/dev/echarts/5.1.1-rc.1/
> >
> > The release candidate is signed with a GPG key available at:
> > https://dist.apache.org/repos/dist/dev/echarts/KEYS
> >
> > The Git commit for this release is:
> >
> >
> https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=786af8b3a55c855425f3825ff663e1856fcb1cf2
> >
> > The Release Note is available in:
> >
> https://dist.apache.org/repos/dist/dev/echarts/5.1.1-rc.1/RELEASE_NOTE.txt
> >
> > Build Guide:
> > https://github.com/apache/echarts/blob/5.1.1-rc.1/README.md#build
> >
> > Please vote on releasing this package as:
> > Apache ECharts 5.1.1 (release candidate 1)
> > by "2021-04-27T02:18:10.952Z".
> >
> > [ ] +1 Release this package
> > [ ] 0 I don't feel strongly about it, but don't object
> > [ ] -1 Do not release this package because...
> >
> > Anyone can participate in testing and voting, not just committers, please
> > feel free to try out the release candidate and provide your votes.
> >
> > A checklist for reference:
> >
> >
> https://cwiki.apache.org/confluence/display/ECHARTS/Apache+ECharts+Release+Checklist
> >
> > --
> > Yi Shen
> > Apache ECharts PMC
> >
> >
> >
>
> --
> Yi Shen
> Apache ECharts PMC
>

Reply via email to