brnnnfx opened a new pull request #34:
URL: https://github.com/apache/echarts-handbook/pull/34


   **What is this change?**
   
   - Fixed broken graphics in `basic-bar.md`
   
   Atempts to embed iFrames should be removed because the links are dead and 
[`<iframe>` is not supported by GitHub-flavoured 
Markdown](https://github.github.com/gfm/#example-652), however, I am not able 
to find suitable replacements at this time so I've left them in.
   
   BEFORE (as-is)
   
   
![b4](https://user-images.githubusercontent.com/12024098/149457607-63692d8e-8689-40ee-b1ad-44964cc199bd.png)
   
   AFTER (to-be)
   
   
![after](https://user-images.githubusercontent.com/12024098/149457656-99057b91-1adc-4421-9ef5-5e56827b255b.png)
   
   **Why is this change necessary?**
   
   These change will  provide a more polished reading experience for project 
contributors and consumers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Reply via email to