+1 (binding) I checked: - The release file is in the right location - sha512 and asc is correct. - Version is correct in package.json and src/core/echarts.ts - The source code is the same as the GitHub tag "5.4.1-rc.1". - LICENSE is correct. - RELEASE_NOTE exists and is correct. - Download and npm install and build OK. - Can run examples from build.
Thanks, ------------------------------ Su Shuang (100pah) ------------------------------ On Thu, 8 Dec 2022 at 02:18, SHUANG SU <sushuang0...@gmail.com> wrote: > Hi, siwen, > > It seems that your KEY is not in > https://dist.apache.org/repos/dist/dev/echarts/KEYS ? > Could you add it into that file? > > Thanks, > ------------------------------ > Su Shuang (100pah) > ------------------------------ > > > > On Mon, 5 Dec 2022 at 14:07, Ovilia <oviliazh...@gmail.com> wrote: > >> +1 >> >> Checked: >> >> - The release file is in the right location >> >> - Signature and hash are correct >> >> - Version is correct in package.json >> >> - LICENSE and NOTICE file exist >> >> - NOTICE year correct >> >> - RELEASE_NOTE.txt is correct >> >> - Can build from source. >> >> >> Thanks >> >> *Ovilia* >> >> >> On Mon, Dec 5, 2022 at 12:03 AM Zhongxiang Wang <wan...@apache.org> >> wrote: >> >> > +1 (binding) >> > >> > Checked as follows, >> > >> > - The release files are in the right place >> > - GPG verified and SHASUM is correct >> > - Version is correct in package.json (5.4.1) >> > - LICENSE and NOTICE exist >> > - The year in NOTICE is correct (2022) >> > - RELEASE_NOTE.txt is correct (With version 5.4.1) >> > - Can build from the source code (Via `npm run release`) >> > - The examples for check works well with built files >> > >> > Thanks for your work! :) >> > >> > On Fri, Dec 2, 2022 at 9:38 PM siwen su <susiw...@gmail.com> wrote: >> > >> > > --- Mail To: --- >> > > dev@echarts.apache.org >> > > ----------------------------------------------------------- >> > > >> > > --- Subject: --- >> > > [VOTE] Release Apache ECharts 5.4.1 (release candidate 1) >> > > ----------------------------------------------------------- >> > > >> > > Dear community, >> > > >> > > We are pleased to be calling this vote for the release of Apache >> ECharts >> > > 5.4.1 (release candidate 1). >> > > >> > > The release candidate to be voted over is available at: >> > > https://dist.apache.org/repos/dist/dev/echarts/5.4.1-rc.1/ >> > > >> > > The release candidate is signed with a GPG key available at: >> > > https://dist.apache.org/repos/dist/dev/echarts/KEYS >> > > >> > > The Git commit for this release is: >> > > >> > > >> > >> https://gitbox.apache.org/repos/asf?p=echarts.git;a=commit;h=c308ec76f20f5dadcd04d2a10eeee9e06fbdad81 >> > > >> > > The Release Note is available in: >> > > >> > >> https://dist.apache.org/repos/dist/dev/echarts/5.4.1-rc.1/RELEASE_NOTE.txt >> > > >> > > Build Guide: >> > > https://github.com/apache/echarts/blob/5.4.1-rc.1/README.md#build >> > > >> > > NPM Install: >> > > npm i echarts@5.4.1-rc.1 >> > > https://www.npmjs.com/package/echarts/v/5.4.1-rc.1 >> > > >> > > Please vote on releasing this package as: >> > > Apache ECharts 5.4.1 (release candidate 1) >> > > by "2022-12-04T23:15:32.995Z". >> > > >> > > [ ] +1 Release this package >> > > [ ] 0 I don't feel strongly about it, but don't object >> > > [ ] -1 Do not release this package because... >> > > >> > > Anyone can participate in testing and voting, not just committers, >> please >> > > feel free to try out the release candidate and provide your votes. >> > > >> > > A checklist for reference: >> > > >> > > >> > >> https://cwiki.apache.org/confluence/display/ECHARTS/Apache+ECharts+Release+Checklist >> > > >> > >> >
