Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-edgent/pull/181#discussion_r75764099
--- Diff: build.gradle ---
@@ -29,6 +29,21 @@ allprojects {
apply plugin: 'java'
+/* SET PROJECT INFO for all artifacts */
+assert hasProperty('version') // See version in gradle.properties.
+System.out.println("version=${version}")
--- End diff --
First let me say Thanks for the Contribution! I'm new to gradle so excuse
nubie questions.
I don't understand the value of this assert & println.
All projects have a 'version' property so the assert will never fail.
The println prints `version=unspecified` because the property hasn't been
set -- gradle.properties defines `build_version` (later in the script it sets a
subproject's version to build_version -- I don't know why the author chose to
do it that way).
Should the above lines just be removed / were they for your initial
debugging?
Regarding 'group', it feels to me like it should be handled to version /
build_version, originating from gradle.properties. Your thought on that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
