GitHub user dlaboss opened a pull request:
https://github.com/apache/incubator-edgent/pull/201
[WIP] Edgent-251 adapt Eclipse to not use 3rd-party repo jars
- add 'setupExternalJars' gradle task
- change .classpath files to reference ext jars in build/distribution/...
Note, the changes DO NOT include removal of the 3rd party jars from our
repo (though in my workspace I removed them and Eclipse builds/test of
Edgent worked fine). A separate issue/PR will be used to remove them.
This approach has the same characteristics as the current Eclipse/ant
build environments: separate project dependency specifications, separate
class file locations, Eclipse builds/tests don't use the ant/gradle
built Edgent jars.
My initial experience trying to use the Buildship gradle/Eclipse
integration came up short. The way it created/updated .classpath files
as a result of the way dependencies are expressed in our build.gradle
files was problematic. So, I scoped back to the approach here to get to
the end-goal (removal of dependency of 3rd party jars in the repo) asap.
Should revisit the buildship env later to see if things can be made to
work.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlaboss/incubator-edgent gradleEclipse
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-edgent/pull/201.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #201
----
commit 9fe77e7f4a2a6156822664c505950fc61f7fcf45
Author: Dale LaBossiere <[email protected]>
Date: 2016-09-29T17:41:26Z
[WIP] [ci-skip] Edgent-251 adapt Eclipse to not use 3rd-party repo jars
- add 'setupExternalJars' gradle task
- change .classpath files to reference ext jars in
build/distribution/...
Note, the changes DO NOT include removal of the 3rd party jars from our
repo (though in my workspace I removed them and Eclipse builds/test of
Edgent worked fine). A separate issue/PR will be used to remove them.
This approach has the same characteristics as the current Eclipse/ant
build environments: separate project dependency specifications, separate
class file locations, Eclipse builds/tests don't use the ant/gradle
built Edgent jars.
My initial experience trying to use the Buildship gradle/Eclipse
integration came up short. The way it created/updated .classpath files
as a result of the way dependencies are expressed in our build.gradle
files was problematic. So, I scoped back to the approach here to get to
the end-goal (removal of dependency of 3rd party jars in the repo) asap.
Should revisit the buildship env later to see if things can be made to
work.
commit c8cb148de41ad40e9a3c3a69cf6952e2f97d3c83
Author: Dale LaBossiere <[email protected]>
Date: 2016-09-29T18:13:30Z
additional development doc updates
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
