Hi,

The info looks good, but it’s not really in line with what is recommend to do 
[1] If it put up for an incubator vote, it IMO is likely to pass (given 
everything else is good) but is likely to get a few “please fix in next 
release” comments.

My minor concerns are:
- LICENSE doesn’t include the text of 3rd party licenses but points to another 
file.
- Some license are referred to by URL, information at that URL can change over 
time. It’s best to download and include a copy of that license.
- pointing to content inside a jar required the user to unpack that jar to se 
ether information. IMO better to copy all license files into a seperate 
directory where they can be clearly seen.
- May not be complying with some 3rd party license terms. While the licenses 
are permissive most licenses state you need to include the full text of the 
license in anything you distribute.
- NOTICE refers to the same external file as LICENSE. NOTICE and LICENSE are 
for different purposes and in general NOTICE doesn't include licensing 
information.
- NOTICE may be missing [2] information from bundled ASLv2 software NOTICE 
files. [2]

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html
2. http://www.apache.org/dev/licensing-howto.html#mod-notice

Reply via email to