[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802603#comment-15802603 ]
ASF GitHub Bot commented on EDGENT-327: --------------------------------------- Github user dlaboss commented on a diff in the pull request: https://github.com/apache/incubator-edgent-website/pull/88#discussion_r94857262 --- Diff: site/_config.yml --- @@ -126,9 +126,9 @@ host: 127.0.0.1 sourcerepourl: https://github.com/apache/incubator-edgent downloadsurl: /docs/downloads projurl: / -#docsurl: /javadoc/latest +docsurl: /javadoc/latest # above yields things like the following when running on a "jekyll serve" test server # [2016-12-22 15:23:31] ERROR `/favicon.ico' not found. # [2016-12-22 15:33:17] ERROR `/javadoc/latest/resources/fonts/dejavu.css' not found. # the following is undesirable as it doesn't link to the "jekyll serve" test server -docsurl: https://edgent.incubator.apache.org/javadoc/latest +# docsurl: https://edgent.incubator.apache.org/javadoc/latest --- End diff -- Yeah, I thought the javadoc looked correct too but wasn't confident they were completely benign. But even if benign, I think it's a bad idea to commit something that's generating them. At best folks will be later be surprised / confused by them. > some http urls in the website prevent full local testing > -------------------------------------------------------- > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site > Reporter: Dale LaBossiere > Assignee: Queenie Ma > Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)