Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-edgent/pull/309#discussion_r127965283
--- Diff: console/servlets/pom.xml ---
@@ -49,23 +56,60 @@
</executions>
<configuration>
<excludes combine.children="append">
- <!-- TODO: Is this correct? I'd suggest to auto-download
jquery and jquery-ui and include that to the output as part of the build -->
- <!--
- <dependency>
- <groupId>org.webjars</groupId>
- <artifactId>jquery-ui</artifactId>
- <version>1.11.4</version>
- </dependency>
- <dependency>
- <groupId>org.webjars</groupId>
- <artifactId>jquery</artifactId>
- <version>1.11.2</version>
- </dependency>
- -->
+ <!-- TODO: Still got one unlicensed file in there ... -->
--- End diff --
Please update the top level source LICENSE file to reflect only what's now
bundled in the source.
Presumably the WAR's included LICENSE continues to require noting that it
bundles d3,jquery,...?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
