Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-edgent/pull/314#discussion_r128285101
--- Diff:
utils/metrics/src/main/java/org/apache/edgent/metrics/MetricsSetup.java ---
@@ -104,15 +104,6 @@ public MetricsSetup startJMXReporter(String
jmxDomainName) {
*/
public MetricsSetup startCSVReporter(String pathMetrics) {
- if (pathMetrics == null) { // pathMetrics is NULL
- pathMetrics = createDefaultDirectory();
- } else {
- File directory = new File(pathMetrics);
- if (!directory.exists() && !directory.mkdirs()) {
- pathMetrics = createDefaultDirectory();
- }
- }
-
--- End diff --
Is the pathMetrics javadoc still accurate with this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
