Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-edgent/pull/315#discussion_r130367741
--- Diff:
utils/metrics/src/main/java/org/apache/edgent/metrics/MetricsSetup.java ---
@@ -111,6 +144,25 @@ private MBeanServer mbeanServer() {
}
return mBeanServer;
}
+
+ /**
+ * Creates a default directory for metrics.
+ *
+ * @return directory.getPath()
+ */
+ private String createDefaultDirectory() {
+ Path currentRelativePath = Paths.get("");
+ String pathMetrics =
currentRelativePath.toAbsolutePath().toString() + FOLDER_METRICS;
+ File directory = new File(pathMetrics);
+
+ if (!directory.mkdirs()) {
+ // Log: "Could not create the directory log"
--- End diff --
Can you fill in the logging? Edgent uses slf4j for
[logging](https://github.com/apache/incubator-edgent/blob/master/DEVELOPMENT.md#logging).
Sample use of it can be seen in
[MqttConnector.java](https://github.com/apache/incubator-edgent/blob/master/connectors/mqtt/src/main/java/org/apache/edgent/connectors/mqtt/runtime/MqttConnector.java).
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
