[
https://issues.apache.org/jira/browse/EDGENT-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114800#comment-16114800
]
ASF GitHub Bot commented on EDGENT-428:
---------------------------------------
Github user dlaboss commented on a diff in the pull request:
https://github.com/apache/incubator-edgent/pull/315#discussion_r131459749
--- Diff:
utils/metrics/src/main/java/org/apache/edgent/metrics/MetricsSetup.java ---
@@ -111,6 +144,25 @@ private MBeanServer mbeanServer() {
}
return mBeanServer;
}
+
+ /**
+ * Creates a default directory for metrics.
+ *
+ * @return directory.getPath()
+ */
+ private String createDefaultDirectory() {
+ Path currentRelativePath = Paths.get("");
+ String pathMetrics =
currentRelativePath.toAbsolutePath().toString() + FOLDER_METRICS;
+ File directory = new File(pathMetrics);
+
+ if (!directory.mkdirs()) {
+ // Log: "Could not create the directory log"
--- End diff --
I'm going to merge this now. Thomas, when you get a chance it would be
great to add the logging. Thanks!
> Adding support for csv in MetricsSetup
> --------------------------------------
>
> Key: EDGENT-428
> URL: https://issues.apache.org/jira/browse/EDGENT-428
> Project: Edgent
> Issue Type: New Feature
> Components: Utils
> Affects Versions: Apache Edgent 1.1.0
> Environment: Raspberry PI
> Reporter: Thomas Cristanis Cabral Nogueira
> Assignee: Dale LaBossiere
> Priority: Minor
> Labels: features
> Fix For: Apache Edgent 1.1.0
>
> Attachments: Screen Shot 2017-07-18 at 09.34.36.png, Screen Shot
> 2017-07-18 at 09.35.24.png, Screen Shot 2017-07-19 at 11.48.37.png
>
>
> In the current project status only had the support will JMX. So it was
> implementing the support to generate .csv files in accordance with [metrics
> library|http://metrics.dropwizard.io/3.1.0/manual/core/#man-core-reporters-csv]
> already used in the project.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)