[ 
https://issues.apache.org/jira/browse/EMPIREDB-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886743#comment-16886743
 ] 

Rainer Döbele commented on EMPIREDB-296:
----------------------------------------

Hi Jan,

had a quick look and found, that probably, in order to be consistent, in 
Page.java you should rather call getPage().getKeyFromParam() instead of 
FacesUtils.getParameterMap().get() like in the other loadRecord() function.

(Just a very minor suggestion)

i.e.:
{quote}    public void loadRecord(PageDefinition page, String idParam) {
        Object[] key = getPage().getKeyFromParam(page, rowset, idParam);
        loadRecord(key);
    }

{quote}

> ParameterMap: allow page-specific idParams
> ------------------------------------------
>
>                 Key: EMPIREDB-296
>                 URL: https://issues.apache.org/jira/browse/EMPIREDB-296
>             Project: Empire-DB
>          Issue Type: Improvement
>          Components: JSF2 Extensions
>    Affects Versions: empire-db-2.4.7
>            Reporter: jan
>            Assignee: jan
>            Priority: Major
>             Fix For: empire-db-2.5.0
>
>
> It should be possible to generate id params for specific pages. This is 
> useful when you have a read only page for everything and a read-write view 
> for subset of the items.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to