Rainer Döbele created EMPIREDB-491:
--------------------------------------

             Summary: DBQuery: swap collections for DBQueryColumns and original 
query columns
                 Key: EMPIREDB-491
                 URL: https://issues.apache.org/jira/browse/EMPIREDB-491
             Project: Empire-DB
          Issue Type: Improvement
          Components: Core
            Reporter: Rainer Döbele
            Assignee: Rainer Döbele


Historically DBQuery used the columns collection inherited from DBRowSet to 
hold the column expressions of the underlying query. Hence DBQuery.getColumns() 
retured the underlying table columns rather than DBQueryColumn which reference 
the query. Accordingly the function DBQuery.getQueryColumns() returned the 
collection of DBQueryColumn.

This led to several special case handlings for DBQuery.

A cleaner approach ist to use the olumns collection inherited from DBRowSet for 
the DBQueryColumns created for this query and vice versa use 
DBQuery.getQueryColumns() to return the underlying query columns. However to 
provide backward compatibility access to the underlying query columns should be 
named differently.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to