ruanwenjun commented on pull request #434: URL: https://github.com/apache/incubator-eventmesh/pull/434#issuecomment-879830719
@yzhao244 It might be better to add a new module such like `eventmesh-store-plugin`, and make the `eventmesh-store-h2` as a submodule of `eventmesh-store-plugin`, this makes it easier to manage plugins. And we have recently enhanced the SPI module #419, you can use `EventMeshExtensionFactory.getExtension(Class<T> extensionType, String extensionName)` to get plugin instance rather than using `ServiceLoader`. You can find some detail of SPI in `eventmesh-connector-rocketmq` module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
