ruanwenjun commented on issue #451:
URL: 
https://github.com/apache/incubator-eventmesh/issues/451#issuecomment-884703756


   @ruanwenjun Yes, you are right.
   When the `AbrstractHTTPServer.java` start, it will new a 
`HttpsServerInitializer` and execute `SSLContextFactory.getSslContext()` to 
inject the `SSLContext `. The problem is in the `getSslContext` doesn't judge 
the ssl open.
   
   
![image](https://user-images.githubusercontent.com/22415594/126601820-25f24c93-db78-48b2-ba18-a00e277b4ba4.png)
   
   It might be better to change the code to below:
   ```java
   SSLContext sslContext = useTLS ? SSLContextFactory.getSslContext() : null;
   b.group(this.bossGroup, this.workerGroup)
           .channel(NioServerSocketChannel.class)
           .childHandler(new 
HttpsServerInitializer(sslContext)).childOption(ChannelOption.SO_KEEPALIVE, 
Boolean.TRUE);
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to