ruanwenjun commented on pull request #475: URL: https://github.com/apache/incubator-eventmesh/pull/475#issuecomment-888753226
@Jackzeng1224 You mean the `pushlish` method is a ASYNC request ? But I don't see any callback in this method, and it seems that the `ProtocolKey.ClientInstanceKey.SYS` is just a system param, we may don't need to change this. Our disagreement is that I think the `request(LiteMessage message, RRCallback rrCallback, long timeout)` should send an async request, if I am wrong, please tell me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
