JunjieChou commented on a change in pull request #545: URL: https://github.com/apache/incubator-eventmesh/pull/545#discussion_r731089463
########## File path: eventmesh-schema-registry/eventmesh-schema-registry-plugin/eventmesh-schema-registry-common/src/main/java/org/apache/eventmesh/schema/registry/domain/SchemaWithSubjectName.java ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.eventmesh.schema.registry.domain; + +import lombok.*; + +@Setter +@Getter +@AllArgsConstructor +@NoArgsConstructor +@Builder +public class SchemaWithSubjectName { + private long id; + + private String name; + + private String comment; + + private String serialization; + + private String schemaType; + + private String schemaDefinition; + + private String validator; + + private int version; + + private String subject; Review comment: Compatibility is an attribute of subject. Check [design doc](https://github.com/apache/incubator-eventmesh/blob/develop/docs/en/features/eventmesh-schemaregistry-design.md) and [schema registry server side](https://github.com/apache/incubator-eventmesh/tree/develop/eventmesh-schema-registry/eventmesh-schema-registry-server) for design of classes. Also, welcome for code improvements if you have a better way for organizing it. Btw, the community has a new plan for schema registry, so I will close this pr, and further come back with a schema registry client side SDK. Would like to hear your idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
