horoc commented on code in PR #2902:
URL:
https://github.com/apache/incubator-eventmesh/pull/2902#discussion_r1086977511
##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/EventMeshGrpcConsumer.java:
##########
@@ -130,7 +144,7 @@ public void subscribe(List<SubscriptionItem>
subscriptionItems) {
private void addSubscription(List<SubscriptionItem> subscriptionItems,
String url) {
for (SubscriptionItem item : subscriptionItems) {
- subscriptionMap.put(item.getTopic(), new SubscriptionInfo(item,
url));
+ subscriptionMap.putIfAbsent(item.getTopic(), new
SubscriptionInfo(item, url));
Review Comment:
> ok,I fix it. @horoc
@jonyangx seems it modified to ```putIfAbsent``` here again in the later
commit ``` 5d7e502 :
fix license check error```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]