eight-nines commented on code in PR #3073:
URL:
https://github.com/apache/incubator-eventmesh/pull/3073#discussion_r1103649382
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/config/ConfigMonitorService.java:
##########
@@ -34,8 +34,7 @@ public class ConfigMonitorService {
private final List<ConfigInfo> configInfoList = new ArrayList<>();
- private final ScheduledExecutorService configLoader = ThreadPoolFactory
- .createSingleScheduledExecutor("eventMesh-configLoader-");
+ private final ScheduledExecutorService configLoader =
ThreadPoolFactory.createSingleScheduledExecutor("eventMesh-configLoader");
Review Comment:
This is a very nice modification point to help keep the consistency of EM
thread naming; you can modify the name and description of the PR; at the same
time, EM about the thread naming prefix, there is also this naming style, the
code is here: org/apache/eventmesh/runtime/core/protocol/http/push/
HTTPMessageHandler.java:52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
