MovieTone opened a new pull request, #4741: URL: https://github.com/apache/eventmesh/pull/4741
Fixes #4734 ### Motivation In Java, it is a best practice to declare a logger static final. private - so that no other class can hijack your logger static - so there is only one logger instance per class, also avoiding attempts to serialize loggers final - no need to change the logger over the lifetime of the class ### Modifications For all `private final Logger` declarations a `static` modifier has been added and the UPPER_CASE has been applied. Logger names has been substituted with constants from `org.apache.eventmesh.runtime.constants.EventMeshConstants`, in particular 3 new constants have been added to it. ### Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) - If a feature is not applicable for documentation, explain why? (minor refactoring) - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org For additional commands, e-mail: dev-h...@eventmesh.apache.org
