AaronGhebretinsae opened a new pull request, #4757:
URL: https://github.com/apache/eventmesh/pull/4757
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull
request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this
pull request.
- Fill out the template below to describe the changes contributed by the
pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and
this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes
#<XXX>`.)
-->
Fixes #issue_id
### Motivation
I am currently new to open source contributing and would like to gain
experience solving issues and navigating git in order to become a better
contributor.
### Modifications
-Added appropriate getters and setters for HeartbeatEntity class in
HeartbeatRequestBody.java.
-Updated EventMeshHttpConsumer.java to access aforementioned variables using
correct setters.
-Updated HeartbeatProcessor.java to access aforementioned variables using
correct getters.
### Documentation
At
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java
line 70-75
At eventmesh-sdk
java/src/main/java/org/apache/eventmesh/client/http/consumer/EventMeshHttpConsumer.java
line 120,121
At
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HeartBeatProcessor.java
line 115,116
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: dev-h...@eventmesh.apache.org
