Whitegabriella789 opened a new pull request, #232:
URL: https://github.com/apache/eventmesh-site/pull/232
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull
request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this
pull request.
- Fill out the template below to describe the changes contributed by the
pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and
this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes
#<XXX>`.)
-->
Fixes #159
### Motivation
*Explain the content here.*
The content of the EventMesh Runtime documentation was outdated and
contained incorrect references to the EventMesh Connector. The documentation
needed updates to ensure accurate instructions for configuring EventMesh
Storage, as well as correcting/checking image paths and terminology.
*Explain why you want to make the changes and what problem you're trying to
solve.*
The changes were made to address user confusion regarding the correct setup
and usage of EventMesh Storage and Connectors, as highlighted in issues #159
and #4680. This ensures users can correctly configure and deploy EventMesh with
RocketMQ as the storage layer.
### Modifications
*Describe the modifications you've done.*
* Updated all references from "EventMesh Connector" to "EventMesh Storage"
where applicable.
* Checked the image path to make sure it started with /static/images/ so
images are correctly displayed.
* Revised configuration instructions to specify
eventMesh.storage.plugin.type=rocketmq instead of
eventMesh.connector.plugin.type.
* Added a note at the bottom to clarify the distinction between EventMesh
Connectors and EventMesh Storage, including their deployment and configuration.
Do let me know if there's anything that needs fixing or if I understood the
instructions wrong. Thanks!
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
- If a feature is not applicable for documentation, explain why? not
applicable
- If a feature is not documented yet in this PR, please create a followup
issue for adding the documentation. not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: dev-h...@eventmesh.apache.org
