[ 
https://issues.apache.org/jira/browse/FALCON-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016265#comment-14016265
 ] 

Shwetha G S commented on FALCON-369:
------------------------------------

[~svenkat], thanks for your feedback. Attached is the class diagram for the 
workflow builder. It separates out different lifecycles(with respect to oozie 
entities), however doesn't add lifecycle as separate entity. Adding lifecycle 
can be discussed and addressed as part of another jira. It will be one to one 
mapping to oozie entities. 

Its a big patch and I will not be able to rebase with new commits. I need this 
refactoring for adding dry run feature. Can you please take a look at the 
earliest? Thanks

> Refactor workflow builder
> -------------------------
>
>                 Key: FALCON-369
>                 URL: https://issues.apache.org/jira/browse/FALCON-369
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>         Attachments: FALCON-369.patch, FalconWorkflowBuilder.png
>
>
> Currently, feed/process workflow builder is a single class which handles all 
> different cases of lifecycles, storage types, workflow engines and building 
> all oozie entities(workflow, coord and bundle). This is not readable and 
> difficult to maintain. This needs some re-factoring.
> Approach:
> Maintain different builders for
> 1. oozie entities - workflow, coord and bundle. 
> 2. entity types - feed and process
> 3. lifecycle - process, retention and replication
> 4. workflow engines - oozie, pig and hive



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to