----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30116/#review69139 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/lock/MemoryLocks.java <https://reviews.apache.org/r/30116/#comment113761> Nit : Rename method to acquireLock? common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java <https://reviews.apache.org/r/30116/#comment113763> MemoryLocks doesn't really belong here as it not stored in the config store. But, I understand you'll want a single instance of MemoryLocks. So, may be have a helper class for that. Or, make MemoryLocs a singleton and have it issue a "named set of locks" common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java <https://reviews.apache.org/r/30116/#comment113765> Seems like the getUpdateLock and releaseUpdateLock are not really adding much value here. May be they can be part of the MemoryLocks itself? prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java <https://reviews.apache.org/r/30116/#comment113766> Nit: May be the message can be a little more user friendly, something like, "looks like an update is already in progress for the entity" webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java <https://reviews.apache.org/r/30116/#comment113772> Since the update method is a synchronous call, don't think the test is simulating parallel update requests. The second update is called after the first one. Also, the second request should have really failed if the first one was still in progress, as an exception would be thrown. context.assertFailed(duplicateUpdateCommandResponse). - Pallavi Rao On Jan. 21, 2015, 12:15 p.m., Suhas Vasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30116/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 12:15 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > In distributed mode, when parallel update command are issued for same entity, > they are not syncronized. > This leads to multiple coordinators being spawned in Oozie. > > We need to ensure that the update method is syncronized. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/lock/MemoryLocks.java > PRE-CREATION > common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java > 1c1c325 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 4a686e7 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 40f8e04 > > Diff: https://reviews.apache.org/r/30116/diff/ > > > Testing > ------- > > UT's were added and were successful > > > Thanks, > > Suhas Vasu > >
