> On Jan. 27, 2015, 8:50 p.m., Raghav Gautam wrote: > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java, > > line 296 > > <https://reviews.apache.org/r/30322/diff/1/?file=836390#file836390line296> > > > > getStatus() call returns an enum - it need not be converted to string > > for equality comparison.
We have two different enums there: InstancesResult.WorkflowStatus and EntitySummaryResult.WorkflowStatus. So we should use either .getOrdinal() or .toString() method for that. I prefer second one because we print these statuses then. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30322/#review69882 ----------------------------------------------------------- On Jan. 27, 2015, 4:22 p.m., Paul Isaychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30322/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 4:22 p.m.) > > > Review request for Falcon. > > > Bugs: Falcon-1007 > https://issues.apache.org/jira/browse/Falcon-1007 > > > Repository: falcon-git > > > Description > ------- > > Modify test logging messages to make debugging easier, change variable names > for better readability of code. > > > Diffs > ----- > > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java > 591810d > > Diff: https://reviews.apache.org/r/30322/diff/ > > > Testing > ------- > > Tested > > > Thanks, > > Paul Isaychuk > >
