[
https://issues.apache.org/jira/browse/FALCON-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14325529#comment-14325529
]
Srikanth Sundarrajan commented on FALCON-1003:
----------------------------------------------
There seems to be an issue with the patch.
{noformat}
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32.229s
[INFO] Finished at: Wed Feb 18 12:52:01 IST 2015
[INFO] Final Memory: 32M/416M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.13:check (checkstyle-check)
on project falcon-main: You have 382 Checkstyle violations. -> [Help 1]
[ERROR]
{noformat}
For some reason the checkstyle seems to apply for directories outside of falcon
checkout dir. Can you check?
Error is predominantly on *.properties
{noformat}
File does not end with a newline.
{noformat}
> Update checkstyle to remove DoubleCheckedLocking
> ------------------------------------------------
>
> Key: FALCON-1003
> URL: https://issues.apache.org/jira/browse/FALCON-1003
> Project: Falcon
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Pallavi Rao
> Assignee: Pallavi Rao
> Priority: Trivial
> Attachments: FALCON-1003-v2.patch, FALCON-1003-v3.patch,
> FALCON-1003-v4.patch, FALCON-1003.patch
>
>
> As per, http://checkstyle.sourceforge.net/releasenotes.html, Release 5.6
> onwards - "Removed the DoubleCheckedLocking check, as in Java 5 (and beyond),
> using the volatile keyword addresses the issue. See here for more details."
> Primary reason for removing this is, I couldn't load the existing checkstyle
> file in my IntelliJ checkstyle plugin because DoubleCheckedLocking check was
> enabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
