----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31221/#review73513 -----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java <https://reviews.apache.org/r/31221/#comment119872> LOGGER.warn can be used. falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java <https://reviews.apache.org/r/31221/#comment119873> what happens for KILLED jobs ? is there no log file url for them ? falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java <https://reviews.apache.org/r/31221/#comment119874> its better to remane the var to coloHelper falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java <https://reviews.apache.org/r/31221/#comment119875> using "0" index might give error for feed bundle, where replication and retention coords are present. i think we already have methods to get correct coord from bundle. that can be used here . falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java <https://reviews.apache.org/r/31221/#comment119876> we have methods in util to get latest bundle id. same should be used here. "get(0)" wont be required after that. - samarth gupta On Feb. 20, 2015, 7:16 a.m., PRAGYA MITTAL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31221/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 7:16 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1040 > https://issues.apache.org/jira/browse/FALCON-1040 > > > Repository: falcon-git > > > Description > ------- > > Using the "actions" in InstanceResult for -status feature populates all the > actions & their corresponding job urls in it as part of > https://issues.apache.org/jira/browse/FALCON-813 . > Modified test for the same. > > > Diffs > ----- > > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java > 3524355 > > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java > d74864f > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceStatusTest.java > e1e7dc1 > > Diff: https://reviews.apache.org/r/31221/diff/ > > > Testing > ------- > > Tested. > > > Thanks, > > PRAGYA MITTAL > >
