> On March 3, 2015, 12:15 p.m., Srikanth Sundarrajan wrote: > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 98 > > <https://reviews.apache.org/r/31672/diff/2/?file=882849#file882849line98> > > > > Is it going to be force-rerun & rerun or rerun & continue ? Looks like > > we are gravitating towards the former.
With this patch, its gonna be -rerun & -rerun -force > On March 3, 2015, 12:15 p.m., Srikanth Sundarrajan wrote: > > webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java, line > > 233 > > <https://reviews.apache.org/r/31672/diff/2/?file=882856#file882856line233> > > > > Can tests be added? Also this is user facing feature. Docs are needed. I was thinking of adding docs in a seperate ticket, but anyway will add in the next patch. Since we first need to wait for an instance to SUCCEED & then do rerun, I feel sufficient tests should be added in regression rather than at build time. - Suhas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31672/#review74937 ----------------------------------------------------------- On March 3, 2015, 9:28 a.m., Suhas Vasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31672/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 9:28 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Falcon rerun does not work for succeeded instances. > ProcessInstanceRerunTest.testProcessInstanceRerunMultipleSucceeded and > ProcessInstanceRerunTest.testProcessInstanceRerunSingleSucceeded is failing > becuase of this. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java ac76a9c > client/src/main/java/org/apache/falcon/client/FalconClient.java 86397c4 > > common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java > 6b10679 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 169856c > prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java > ed30869 > prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java > 7f261ce > > prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java > e6cf904 > webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java > d4e0ae0 > > Diff: https://reviews.apache.org/r/31672/diff/ > > > Testing > ------- > > Have verified this manually > > > Thanks, > > Suhas Vasu > >
