----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31668/#review77358 -----------------------------------------------------------
Ship it! Ship It! common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java <https://reviews.apache.org/r/31668/#comment125265> In cluster XSD. <xs:element type="interface" name="interface" maxOccurs="unbounded" minOccurs="3"/> so, we might need to relax this check. - shaik idris On March 16, 2015, 12:05 p.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31668/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 12:05 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1031 > https://issues.apache.org/jira/browse/FALCON-1031 > > > Repository: falcon-git > > > Description > ------- > > Making messaging interface optional in cluster definition. If it is not > specified, user job completion notifications will not be generated for the > processes that belong to the cluster. > > This patch doesn't handle disabling notifications individually for a process. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/ClusterHelper.java 6a363b6 > > common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java > 87b61a4 > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionArgs.java > 0a8be64 > > common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java > a807e80 > common/src/test/resources/config/cluster/cluster-no-messaging.xml > PRE-CREATION > docs/src/site/twiki/EntitySpecification.twiki 66fcd2f > oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java > e5d75fb > oozie/src/main/java/org/apache/falcon/workflow/FalconPostProcessing.java > e5b3704 > oozie/src/main/resources/action/post-process.xml f354351 > > oozie/src/test/java/org/apache/falcon/oozie/workflow/FalconPostProcessingTest.java > f08949d > > Diff: https://reviews.apache.org/r/31668/diff/ > > > Testing > ------- > > UTs added. End-to-end testing done. > > > Thanks, > > Pallavi Rao > >
