----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33516/#review81488 -----------------------------------------------------------
falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java <https://reviews.apache.org/r/33516/#comment131863> lets rename method to appendAndSearch as we don't populate search box with value, but perform search as well falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java <https://reviews.apache.org/r/33516/#comment131862> we need to add a method where we use general search clean (X) button falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java <https://reviews.apache.org/r/33516/#comment131861> IMHO we need java doc explanation why do we count it's size that way falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java <https://reviews.apache.org/r/33516/#comment131857> we need . before png falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableTest.java <https://reviews.apache.org/r/33516/#comment131859> please add short description of scenario falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableTest.java <https://reviews.apache.org/r/33516/#comment131860> please add javadocs to tests falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableTest.java <https://reviews.apache.org/r/33516/#comment131858> we need to add something to test each param close button (small 'x') - Paul Isaychuk On April 24, 2015, 12:34 p.m., Ruslan Ostafiychuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33516/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 12:34 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1173 > https://issues.apache.org/jira/browse/FALCON-1173 > > > Repository: falcon-git > > > Description > ------- > > Tests with wrong search queries, with adding and deleting query components. > > > Diffs > ----- > > > falcon-regression/merlin/src/main/java/org/apache/falcon/regression/ui/search/SearchPage.java > 8c3ae71 > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java > e3aac1d > > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/searchUI/EntitiesTableTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/33516/diff/ > > > Testing > ------- > > All tests passed are running successfully. > > > Thanks, > > Ruslan Ostafiychuk > >
