[
https://issues.apache.org/jira/browse/FALCON-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516420#comment-14516420
]
Shaik Idris Ali commented on FALCON-991:
----------------------------------------
Looks fine, I think we should throw appropriate exception back instead of just
logging here, similar to getWorkflowStatus.
{code}
} catch (OozieClientException e) {
LOG.error("Unable to getcoordinator job for:{} for start:{}
and end: {}", coord.getId(),
start, end);
}
{code}
Also, unrelated to this Jira, the log levels for some of the errors are set to
debug instead of error or warn.
> consolidate get coord actions in OozieWorkflowEngine
> ----------------------------------------------------
>
> Key: FALCON-991
> URL: https://issues.apache.org/jira/browse/FALCON-991
> Project: Falcon
> Issue Type: Improvement
> Reporter: Shwetha G S
> Assignee: Ajay Yadava
> Attachments: FALCON-991-v1.patch, FALCON-991.patch
>
>
> OozieWorkflowEngine.getCoordActions() gets instances by calling
> oozieclient.getCoordAction() for each action. Its not efficient to call oozie
> API for each instance. Instead, doSummaryJobAction() gets all instances in
> bulk using oozieclient.getCoordJobInfo(). But this uses offset which won't
> work with purging of coord actions. A new API was added in oozie to get coord
> actions between timestamps. We should use that for both usecases
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
